[llvm] [llvm-debuginfod-find] Remove old parameter comment (PR #109637)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 23 01:46:05 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-debuginfo
Author: Aiden Grossman (boomanaiden154)
<details>
<summary>Changes</summary>
This patch removes a comment in llvm-debuginfod-find containing all the cl::opt entries, which are redundant after the conversion to using optTable. These seem to have been introduced in #<!-- -->108082 along with a conversion to optTable.
---
Full diff: https://github.com/llvm/llvm-project/pull/109637.diff
1 Files Affected:
- (modified) llvm/tools/llvm-debuginfod-find/llvm-debuginfod-find.cpp (-39)
``````````diff
diff --git a/llvm/tools/llvm-debuginfod-find/llvm-debuginfod-find.cpp b/llvm/tools/llvm-debuginfod-find/llvm-debuginfod-find.cpp
index 1f4404aaa391fc..699fcf8a7dbcd6 100644
--- a/llvm/tools/llvm-debuginfod-find/llvm-debuginfod-find.cpp
+++ b/llvm/tools/llvm-debuginfod-find/llvm-debuginfod-find.cpp
@@ -98,45 +98,6 @@ static void parseArgs(int argc, char **argv) {
exit(1);
}
-/*
-cl::OptionCategory DebuginfodFindCategory("llvm-debuginfod-find Options");
-
-cl::opt<std::string> InputBuildID(cl::Positional, cl::Required,
- cl::desc("<input build_id>"), cl::init("-"),
- cl::cat(DebuginfodFindCategory));
-
-static cl::opt<bool>
- FetchExecutable("executable", cl::init(false),
- cl::desc("If set, fetch a binary file associated with this "
- "build id, containing the executable sections."),
- cl::cat(DebuginfodFindCategory));
-
-static cl::opt<bool>
- FetchDebuginfo("debuginfo", cl::init(false),
- cl::desc("If set, fetch a binary file associated with this "
- "build id, containing the debuginfo sections."),
- cl::cat(DebuginfodFindCategory));
-
-static cl::opt<std::string> FetchSource(
- "source", cl::init(""),
- cl::desc("Fetch a source file associated with this build id, which is at "
- "this relative path relative to the compilation directory."),
- cl::cat(DebuginfodFindCategory));
-
-static cl::opt<bool>
- DumpToStdout("dump", cl::init(false),
- cl::desc("If set, dumps the contents of the fetched artifact "
- "to standard output. Otherwise, dumps the absolute "
- "path to the cached artifact on disk."),
- cl::cat(DebuginfodFindCategory));
-
-static cl::list<std::string> DebugFileDirectory(
- "debug-file-directory",
- cl::desc("Path to directory where to look for debug files."),
- cl::cat(DebuginfodFindCategory));
-
-*/
-
ExitOnError ExitOnDebuginfodFindError;
static std::string fetchDebugInfo(object::BuildIDRef BuildID);
``````````
</details>
https://github.com/llvm/llvm-project/pull/109637
More information about the llvm-commits
mailing list