[llvm] [SDAG] Honor signed arguments in floating point libcalls (PR #109134)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 23 01:00:03 PDT 2024


================
@@ -2205,7 +2205,24 @@ void SelectionDAGLegalize::ExpandFPLibCall(SDNode* Node,
     Results.push_back(Tmp.first);
     Results.push_back(Tmp.second);
   } else {
-    SDValue Tmp = ExpandLibCall(LC, Node, false).first;
+    bool IsSignedArgument = false;
+    switch (LC) {
+    case RTLIB::LDEXP_F32:
+    case RTLIB::LDEXP_F64:
+    case RTLIB::LDEXP_F80:
+    case RTLIB::LDEXP_F128:
+    case RTLIB::LDEXP_PPCF128:
----------------
nikic wrote:

It might be a bit cleaner to check this as `Node->getOpcode() == ISD::FLDEXP`, to cover all libcall variants at once.

https://github.com/llvm/llvm-project/pull/109134


More information about the llvm-commits mailing list