[llvm] [Transforms] Avoid repeated hash lookups (NFC) (PR #109565)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Sat Sep 21 22:45:05 PDT 2024
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/109565
None
>From ae8d4fada1856b5c40d76da0a00daa975b21191c Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Sat, 21 Sep 2024 09:23:11 -0700
Subject: [PATCH] [Transforms] Avoid repeated hash lookups (NFC)
---
llvm/lib/Transforms/IPO/IROutliner.cpp | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/llvm/lib/Transforms/IPO/IROutliner.cpp b/llvm/lib/Transforms/IPO/IROutliner.cpp
index ec72741c06e73d..20d2d46e79ebcc 100644
--- a/llvm/lib/Transforms/IPO/IROutliner.cpp
+++ b/llvm/lib/Transforms/IPO/IROutliner.cpp
@@ -787,10 +787,8 @@ static void findConstants(IRSimilarityCandidate &C, DenseSet<unsigned> &NotSame,
// global value numbering.
unsigned GVN = *C.getGVN(V);
if (isa<Constant>(V))
- if (NotSame.contains(GVN) && !Seen.contains(GVN)) {
+ if (NotSame.contains(GVN) && Seen.insert(GVN).second)
Inputs.push_back(GVN);
- Seen.insert(GVN);
- }
}
}
}
@@ -814,8 +812,9 @@ static void mapInputsToGVNs(IRSimilarityCandidate &C,
// replacement.
for (Value *Input : CurrentInputs) {
assert(Input && "Have a nullptr as an input");
- if (OutputMappings.contains(Input))
- Input = OutputMappings.find(Input)->second;
+ auto It = OutputMappings.find(Input);
+ if (It != OutputMappings.end())
+ Input = It->second;
assert(C.getGVN(Input) && "Could not find a numbering for the given input");
EndInputNumbers.push_back(*C.getGVN(Input));
}
@@ -836,8 +835,9 @@ remapExtractedInputs(const ArrayRef<Value *> ArgInputs,
// Get the global value number for each input that will be extracted as an
// argument by the code extractor, remapping if needed for reloaded values.
for (Value *Input : ArgInputs) {
- if (OutputMappings.contains(Input))
- Input = OutputMappings.find(Input)->second;
+ auto It = OutputMappings.find(Input);
+ if (It != OutputMappings.end())
+ Input = It->second;
RemappedArgInputs.insert(Input);
}
}
More information about the llvm-commits
mailing list