[llvm] [SPIR-V] Enable `spirv-sim` lit substitution unconditionally (PR #109451)

via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 20 10:57:37 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-backend-spir-v

Author: Justin Bogner (bogner)

<details>
<summary>Changes</summary>

The uses of spirv-sim aren't gated by LLVM_INCLUDE_SPIRV_TOOLS_TESTS, so the substitution shouldn't be gated either. Fixes tests after #<!-- -->107408

---
Full diff: https://github.com/llvm/llvm-project/pull/109451.diff


1 Files Affected:

- (modified) llvm/test/CodeGen/SPIRV/lit.local.cfg (+8-7) 


``````````diff
diff --git a/llvm/test/CodeGen/SPIRV/lit.local.cfg b/llvm/test/CodeGen/SPIRV/lit.local.cfg
index 7a20bcc82ad0ff..4655633a256827 100644
--- a/llvm/test/CodeGen/SPIRV/lit.local.cfg
+++ b/llvm/test/CodeGen/SPIRV/lit.local.cfg
@@ -3,15 +3,16 @@ if not "SPIRV" in config.root.targets:
 
 spirv_sim_root = os.path.join(config.llvm_src_root, "utils", "spirv-sim")
 
+config.substitutions.append(
+    (
+        "spirv-sim",
+        "'%s' %s" % (config.python_executable,
+                     os.path.join(spirv_sim_root, "spirv-sim.py")),
+    )
+)
+
 if config.spirv_tools_tests:
     config.available_features.add("spirv-tools")
     config.substitutions.append(("spirv-dis", os.path.join(config.llvm_tools_dir, "spirv-dis")))
     config.substitutions.append(("spirv-val", os.path.join(config.llvm_tools_dir, "spirv-val")))
     config.substitutions.append(("spirv-as", os.path.join(config.llvm_tools_dir, "spirv-as")))
-    config.substitutions.append(
-      (
-        "spirv-sim",
-        "'%s' %s"
-        % (config.python_executable, os.path.join(spirv_sim_root, "spirv-sim.py")),
-      )
-    )

``````````

</details>


https://github.com/llvm/llvm-project/pull/109451


More information about the llvm-commits mailing list