[libc] [llvm] [libc] Add printf strerror conversion (%m) (PR #105891)

Thu Sep 19 11:15:41 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `libc,utils` at step 5 "compile-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/5798

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (compile-openmp) failure: build (failure)
...
25.749 [1371/32/2893] Building CXX object tools/clang/lib/Analysis/CMakeFiles/obj.clangAnalysis.dir/ThreadSafetyCommon.cpp.o
25.750 [1370/32/2894] Building CXX object tools/clang/lib/Analysis/CMakeFiles/obj.clangAnalysis.dir/ThreadSafety.cpp.o
25.750 [1369/32/2895] Building CXX object tools/clang/lib/Analysis/CMakeFiles/obj.clangAnalysis.dir/UninitializedValues.cpp.o
25.767 [1368/32/2896] Linking CXX static library lib/libLLVMDebugInfoGSYM.a
25.768 [1367/32/2897] Linking CXX static library lib/libLLVMDebugInfoPDB.a
25.792 [1366/32/2898] Building CXX object tools/clang/lib/Analysis/CMakeFiles/obj.clangAnalysis.dir/MacroExpansionContext.cpp.o
25.793 [1365/32/2899] Linking CXX static library lib/libLLVMDWP.a
25.793 [1364/32/2900] Building CXX object tools/clang/lib/Analysis/CMakeFiles/obj.clangAnalysis.dir/ThreadSafetyTIL.cpp.o
25.793 [1363/32/2901] Linking CXX static library lib/libLLVMTextAPIBinaryReader.a
25.794 [1362/32/2902] Linking CXX executable bin/amdhsa-loader
FAILED: bin/amdhsa-loader 
: && /usr/bin/c++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -Wl,-rpath-link,/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./lib  -Wl,--gc-sections projects/libc/utils/gpu/loader/CMakeFiles/gpu_loader.dir/Main.cpp.o projects/libc/utils/gpu/loader/amdgpu/CMakeFiles/amdhsa-loader.dir/amdhsa-loader.cpp.o -o bin/amdhsa-loader  -Wl,-rpath,"\$ORIGIN/../lib:/opt/rocm/lib:"  lib/libLLVMBinaryFormat.a  lib/libLLVMObject.a  lib/libLLVMOption.a  lib/libLLVMSupport.a  -lpthread  /opt/rocm/lib/libhsa-runtime64.so.1.12.60002  lib/libllvmlibc_rpc_server.a  lib/libLLVMIRReader.a  lib/libLLVMBitReader.a  lib/libLLVMAsmParser.a  lib/libLLVMCore.a  lib/libLLVMRemarks.a  lib/libLLVMBitstreamReader.a  lib/libLLVMMCParser.a  lib/libLLVMMC.a  lib/libLLVMDebugInfoCodeView.a  lib/libLLVMTextAPI.a  lib/libLLVMBinaryFormat.a  lib/libLLVMTargetParser.a  lib/libLLVMSupport.a  -lrt  -ldl  -lpthread  -lm  /usr/lib/x86_64-linux-gnu/libz.so  lib/libLLVMDemangle.a && :
/usr/bin/ld: lib/libllvmlibc_rpc_server.a(rpc_server.cpp.o): in function `__llvm_libc_20_0_0_git::printf_core::Parser<__llvm_libc_20_0_0_git::internal::DummyArgList<true>&>::get_next_section()':
rpc_server.cpp:(.text._ZN22__llvm_libc_20_0_0_git11printf_core6ParserIRNS_8internal12DummyArgListILb1EEEE16get_next_sectionEv[_ZN22__llvm_libc_20_0_0_git11printf_core6ParserIRNS_8internal12DummyArgListILb1EEEE16get_next_sectionEv]+0x68b): undefined reference to `__llvm_libc_20_0_0_git::libc_errno'
/usr/bin/ld: rpc_server.cpp:(.text._ZN22__llvm_libc_20_0_0_git11printf_core6ParserIRNS_8internal12DummyArgListILb1EEEE16get_next_sectionEv[_ZN22__llvm_libc_20_0_0_git11printf_core6ParserIRNS_8internal12DummyArgListILb1EEEE16get_next_sectionEv]+0x695): undefined reference to `__llvm_libc_20_0_0_git::Errno::operator int()'
/usr/bin/ld: lib/libllvmlibc_rpc_server.a(rpc_server.cpp.o): in function `__llvm_libc_20_0_0_git::printf_core::Parser<__llvm_libc_20_0_0_git::internal::StructArgList<true> >::get_next_section()':
rpc_server.cpp:(.text._ZN22__llvm_libc_20_0_0_git11printf_core6ParserINS_8internal13StructArgListILb1EEEE16get_next_sectionEv[_ZN22__llvm_libc_20_0_0_git11printf_core6ParserINS_8internal13StructArgListILb1EEEE16get_next_sectionEv]+0x5b2): undefined reference to `__llvm_libc_20_0_0_git::libc_errno'
/usr/bin/ld: rpc_server.cpp:(.text._ZN22__llvm_libc_20_0_0_git11printf_core6ParserINS_8internal13StructArgListILb1EEEE16get_next_sectionEv[_ZN22__llvm_libc_20_0_0_git11printf_core6ParserINS_8internal13StructArgListILb1EEEE16get_next_sectionEv]+0x5bc): undefined reference to `__llvm_libc_20_0_0_git::Errno::operator int()'
/usr/bin/ld: lib/libllvmlibc_rpc_server.a(rpc_server.cpp.o): in function `__llvm_libc_20_0_0_git::printf_core::Parser<__llvm_libc_20_0_0_git::internal::DummyArgList<false>&>::get_next_section()':
rpc_server.cpp:(.text._ZN22__llvm_libc_20_0_0_git11printf_core6ParserIRNS_8internal12DummyArgListILb0EEEE16get_next_sectionEv[_ZN22__llvm_libc_20_0_0_git11printf_core6ParserIRNS_8internal12DummyArgListILb0EEEE16get_next_sectionEv]+0x6c3): undefined reference to `__llvm_libc_20_0_0_git::libc_errno'
/usr/bin/ld: rpc_server.cpp:(.text._ZN22__llvm_libc_20_0_0_git11printf_core6ParserIRNS_8internal12DummyArgListILb0EEEE16get_next_sectionEv[_ZN22__llvm_libc_20_0_0_git11printf_core6ParserIRNS_8internal12DummyArgListILb0EEEE16get_next_sectionEv]+0x6cd): undefined reference to `__llvm_libc_20_0_0_git::Errno::operator int()'
/usr/bin/ld: lib/libllvmlibc_rpc_server.a(rpc_server.cpp.o): in function `__llvm_libc_20_0_0_git::printf_core::Parser<__llvm_libc_20_0_0_git::internal::StructArgList<false> >::get_next_section()':
rpc_server.cpp:(.text._ZN22__llvm_libc_20_0_0_git11printf_core6ParserINS_8internal13StructArgListILb0EEEE16get_next_sectionEv[_ZN22__llvm_libc_20_0_0_git11printf_core6ParserINS_8internal13StructArgListILb0EEEE16get_next_sectionEv]+0x5e1): undefined reference to `__llvm_libc_20_0_0_git::libc_errno'
/usr/bin/ld: rpc_server.cpp:(.text._ZN22__llvm_libc_20_0_0_git11printf_core6ParserINS_8internal13StructArgListILb0EEEE16get_next_sectionEv[_ZN22__llvm_libc_20_0_0_git11printf_core6ParserINS_8internal13StructArgListILb0EEEE16get_next_sectionEv]+0x5eb): undefined reference to `__llvm_libc_20_0_0_git::Errno::operator int()'
/usr/bin/ld: lib/libllvmlibc_rpc_server.a(converter.cpp.o): in function `__llvm_libc_20_0_0_git::printf_core::convert(__llvm_libc_20_0_0_git::printf_core::Writer*, __llvm_libc_20_0_0_git::printf_core::FormatSection const&)':
converter.cpp:(.text._ZN22__llvm_libc_20_0_0_git11printf_core7convertEPNS0_6WriterERKNS0_13FormatSectionE+0x3a7): undefined reference to `__llvm_libc_20_0_0_git::try_get_errno_name(int)'
/usr/bin/ld: converter.cpp:(.text._ZN22__llvm_libc_20_0_0_git11printf_core7convertEPNS0_6WriterERKNS0_13FormatSectionE+0x50e): undefined reference to `__llvm_libc_20_0_0_git::get_error_string(int, __llvm_libc_20_0_0_git::cpp::span<char>)'
collect2: error: ld returned 1 exit status
25.813 [1362/31/2903] Building CXX object tools/clang/lib/Analysis/FlowSensitive/CMakeFiles/obj.clangAnalysisFlowSensitive.dir/Arena.cpp.o
25.827 [1362/30/2904] Linking CXX static library lib/libLLVMSymbolize.a
25.837 [1362/29/2905] Linking CXX static library lib/libLLVMJITLink.a
25.852 [1362/28/2906] Linking CXX static library lib/libLLVMObjectYAML.a
25.906 [1362/27/2907] Linking CXX static library lib/libLLVMDebugInfoLogicalView.a
25.965 [1362/26/2908] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CodeGenPGO.cpp.o
26.068 [1362/25/2909] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CoverageMappingGen.cpp.o
26.119 [1362/24/2910] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/ObjectFilePCHContainerWriter.cpp.o
26.184 [1362/23/2911] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CodeGenModule.cpp.o
26.234 [1362/22/2912] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CodeGenAction.cpp.o
26.355 [1362/21/2913] Building CXX object tools/clang/lib/Analysis/plugins/CheckerDependencyHandling/CMakeFiles/CheckerDependencyHandlingAnalyzerPlugin.dir/CheckerDependencyHandling.cpp.o
26.476 [1362/20/2914] Building CXX object tools/clang/lib/Analysis/plugins/SampleAnalyzer/CMakeFiles/SampleAnalyzerPlugin.dir/MainCallChecker.cpp.o
26.550 [1362/19/2915] Building CXX object tools/clang/lib/Analysis/CMakeFiles/obj.clangAnalysis.dir/ReachableCode.cpp.o
26.981 [1362/18/2916] Building CXX object tools/clang/lib/Analysis/CMakeFiles/obj.clangAnalysis.dir/UnsafeBufferUsage.cpp.o
27.608 [1362/17/2917] Building AMDGPUGenCallingConv.inc...
28.423 [1362/16/2918] Building AMDGPUGenPreLegalizeGICombiner.inc...
28.910 [1362/15/2919] Building AMDGPUGenDisassemblerTables.inc...
29.064 [1362/14/2920] Building AMDGPUGenRegBankGICombiner.inc...
29.635 [1362/13/2921] Building AMDGPUGenPostLegalizeGICombiner.inc...
30.237 [1362/12/2922] Building AMDGPUGenMCCodeEmitter.inc...
30.445 [1362/11/2923] Building AMDGPUGenSearchableTables.inc...

```

</details>

https://github.com/llvm/llvm-project/pull/105891