[llvm] [LLVM-C] Add bindings to `Instruction::getDbgRecordRange()` (PR #107802)
Orlando Cazalet-Hyams via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 19 01:40:07 PDT 2024
OCHyams wrote:
> @OCHyams Done.
>
> I don't mind these nitpicks, but I just wanted to mention that many of the nitpicked sentences, like:
>
> * "Advance a [...] iterator"
> * "Go backwards in [...] iterator"
> * "Obtain the next [...] in [...]"
>
> are not my invention and were already used on other docstrings (e.g. `LLVMGet*BasicBlock`). I think it would be great to adjust these now too, to avoid inconsistency. Not sure if I should submit a (separate) PR or you would prefer to do that? I don't mind either way.
Oh right, I hadn't noticed that, thanks for raising this point. If you're happy to submit another PR for that please do (others may have opinions about whether or not its worth changing the wording of those, but fwiw it seems good to me if we can make things consistent and improve clarity)
Do you have commit access? If not I can merge this one for you.
https://github.com/llvm/llvm-project/pull/107802
More information about the llvm-commits
mailing list