[llvm] [llvm][Support] Enable pass timing in StandardInstrumentations constr… (PR #108983)
Arthur Eubanks via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 18 15:13:29 PDT 2024
https://github.com/aeubanks commented:
in general this direction makes sense
I'm not really a fan of the `std::optional<bool>` though. what about just making the param a bool that defaults to `false`, and the `cl::opt` flags override it if they are explicitly specified?
also, we really should make the `StandardInstrumentations` constructor take a `StandardInstrumentationsOptions` as opposed to a bunch of separate params, but that can be a followup
https://github.com/llvm/llvm-project/pull/108983
More information about the llvm-commits
mailing list