[llvm] [NVPTX] Load/Store/Fence syncscope support (PR #106101)
Artem Belevich via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 18 10:56:58 PDT 2024
================
@@ -95,228 +96,262 @@ void NVPTXInstPrinter::printOperand(const MCInst *MI, unsigned OpNo,
}
void NVPTXInstPrinter::printCvtMode(const MCInst *MI, int OpNum, raw_ostream &O,
- const char *Modifier) {
+ const char *M) {
----------------
Artem-B wrote:
Why not make the argument itself StringRef?
Also, it may be a good idea to extract such cosmetic improvements that are not related to the core functionality into a separate patch. It would be trivial to land by itself and will make it easier to review this patch.
https://github.com/llvm/llvm-project/pull/106101
More information about the llvm-commits
mailing list