[llvm] [SimplifyCFG] Pass context instruction to isSafeToSpeculativelyExecute() (PR #109132)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 18 05:57:54 PDT 2024


================
@@ -398,9 +398,6 @@ static void addPredecessorToBlock(BasicBlock *Succ, BasicBlock *NewPred,
 /// expensive.
 static InstructionCost computeSpeculationCost(const User *I,
                                               const TargetTransformInfo &TTI) {
-  assert((!isa<Instruction>(I) ||
-          isSafeToSpeculativelyExecute(cast<Instruction>(I))) &&
-         "Instruction is not safe to speculatively execute!");
----------------
nikic wrote:

I opted to drop this assert rather than pass through extra parameters just for the sake of it.

https://github.com/llvm/llvm-project/pull/109132


More information about the llvm-commits mailing list