[lld] [LLD][COFF] Process all live import symbols in getSymbols() (PR #109117)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 18 05:19:22 PDT 2024


================
@@ -122,16 +122,9 @@ static void getSymbols(const COFFLinkerContext &ctx,
     if (!file->live)
       continue;
 
-    if (!file->thunkSym)
-      continue;
-
-    if (!file->thunkSym->isLive())
-      continue;
-
-    syms.push_back(thunkSym);
-
-    if (auto *impSym = dyn_cast_or_null<Defined>(file->impSym))
----------------
mstorsjo wrote:

So technically, it's not possible for `impSym` to be null, or to be anything else than a `Defined` here?

https://github.com/llvm/llvm-project/pull/109117


More information about the llvm-commits mailing list