[llvm] [SCEV] Add predicate in SolveLinEq to ensure B is a multiple of A. (PR #108777)

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 17 12:32:42 PDT 2024


================
@@ -10137,8 +10140,17 @@ static const SCEV *SolveLinEquationWithOverflow(const APInt &A, const SCEV *B,
   //
   // B is divisible by D if and only if the multiplicity of prime factor 2 for B
   // is not less than multiplicity of this prime factor for D.
-  if (SE.getMinTrailingZeros(B) < Mult2)
-    return SE.getCouldNotCompute();
+  if (SE.getMinTrailingZeros(B) < Mult2) {
+    if (!Predicates)
+      return SE.getCouldNotCompute();
+    // Try to add a predicate ensuring B is a multiple of A.
+    const SCEV *URem = SE.getURemExpr(B, SE.getConstant(A));
----------------
efriedma-quic wrote:

Why `B % A`, and not `B % (1 << Mult2)`?

I don't think this actually impacts any of the existing testcases; probably worth adding a few so we have coverage.

https://github.com/llvm/llvm-project/pull/108777


More information about the llvm-commits mailing list