[llvm] [RISCV] Introduce VLOptimizer pass (PR #108640)

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 17 12:25:44 PDT 2024


preames wrote:

> Does anyone have different ideas or does this sound okay?

First, I want to explicitly say again that I'd welcome this iteration happening in tree.

Second, I don't tend to be a huge fan of C++ unit tests for this kind of API because they end up just repeating the implementation, and are hard to update.  If you want to go in this direction, maybe something along the lines of a printer pass so that diffs can be autogenerated and we only have to (manually) change one place?

Third, part of the problem with getOperandInfo is that it replicates information in other places.  In particular, I think this gets a lot simpler if restructured using the recently added DestEEW mechanism.  



https://github.com/llvm/llvm-project/pull/108640


More information about the llvm-commits mailing list