[llvm] [X86] Don't convert local function foo in the same section to foo(%rip) when the offset is near INT32_MIN (PR #98438)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 17 10:13:52 PDT 2024


MaskRay wrote:

> > The other kinds of errors are prevented by other code, e.g. `isOffsetSuitableForCodeModel` has `return Offset < 16 * 1024 * 1024`.
> 
> @jyknight Does the magic offset used in a similar place make you accept this approach more? :)
> 
> I am happy to change that INT_MIN+256MiB to 16MiB to have consistent magic numbers.

Friendly ping :)

https://github.com/llvm/llvm-project/pull/98438


More information about the llvm-commits mailing list