[llvm] [llvm][Support] Enable pass timing in StandardInstrumentations constr… (PR #108983)
Tom Eccles via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 17 07:58:55 PDT 2024
https://github.com/tblah commented:
This looks okay to me but please wait for approval from somebody who contributes to this area.
One alternative would be to make another constructor with these two arguments (as bools not optionals) and delegate to that from this one. I don't personally feel strongly enough to ask you to change it, but it might fit better with the style used in these classes.
```c++
StandardInstrumentation::StandardInstrumentations(LLVMContext &Context, bool DebugLogging, bool VerifyEach, PrintPassOptions PrintPassOpts) :
StandardInstrumentations(Context, DebugLogging, VerifyEach, PrintPassOpts, TimePassesIsEnabled, TimePassesPerRun) {}
StandardInstrumentation::StandardInstrumentations(LLVMContext &Context, bool DebugLogging, bool VerifyEach, PrintPassOptions PrintPassOpts, bool EnableTimePasses, bool EnablePerRunTiming) :
TimePasses(EnableTimePasses, EnablePerRunTiming),
OptNone(DeubLogging),
[...]
```
https://github.com/llvm/llvm-project/pull/108983
More information about the llvm-commits
mailing list