[llvm] [GISEL] Fix bugs in G_EXTRACT_SUBVECTOR definition (PR #108848)

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 16 14:43:23 PDT 2024


================
@@ -1778,10 +1778,19 @@ void MachineVerifier::verifyPreISelGenericInstruction(const MachineInstr *MI) {
       break;
     }
 
-    if (IndexOp.getImm() != 0 &&
-        SrcTy.getElementCount().getKnownMinValue() % IndexOp.getImm() != 0) {
-      report("Index must be a multiple of the source vector's minimum vector "
-             "length",
+    int64_t Idx = IndexOp.getImm();
+    auto DstMinLen = DstTy.getElementCount().getKnownMinValue();
----------------
topperc wrote:

I'm not sure `auto` here is consistent with llvm's guidelines on using `auto` does getKnownMinValue() return `unsigned` or `uint64_t`? I honestly don't know.

https://github.com/llvm/llvm-project/pull/108848


More information about the llvm-commits mailing list