[llvm] [MC] Explicitly mark MCSymbol for MO_ExternalSymbol (PR #108880)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 16 13:39:57 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-x86
Author: weiwei chen (weiweichen)
<details>
<summary>Changes</summary>
- [x] Mark `MCSymbol` for `MO_ExternalSymbol` to be external when created.
---
Full diff: https://github.com/llvm/llvm-project/pull/108880.diff
1 Files Affected:
- (modified) llvm/lib/Target/X86/X86MCInstLower.cpp (+5-2)
``````````diff
diff --git a/llvm/lib/Target/X86/X86MCInstLower.cpp b/llvm/lib/Target/X86/X86MCInstLower.cpp
index 77ddd2366e629e..949711f35aa584 100644
--- a/llvm/lib/Target/X86/X86MCInstLower.cpp
+++ b/llvm/lib/Target/X86/X86MCInstLower.cpp
@@ -350,8 +350,11 @@ MCOperand X86MCInstLower::LowerMachineOperand(const MachineInstr *MI,
return MCOperand::createImm(MO.getImm());
case MachineOperand::MO_MachineBasicBlock:
case MachineOperand::MO_GlobalAddress:
- case MachineOperand::MO_ExternalSymbol:
- return LowerSymbolOperand(MO, GetSymbolFromOperand(MO));
+ case MachineOperand::MO_ExternalSymbol: {
+ MCSymbol *Sym = GetSymbolFromOperand(MO);
+ Sym->setExternal(true);
+ return LowerSymbolOperand(MO, Sym);
+ }
case MachineOperand::MO_MCSymbol:
return LowerSymbolOperand(MO, MO.getMCSymbol());
case MachineOperand::MO_JumpTableIndex:
``````````
</details>
https://github.com/llvm/llvm-project/pull/108880
More information about the llvm-commits
mailing list