[compiler-rt] [sanitizer] Fix intersecting stacks workaround (PR #108672)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 16 01:54:09 PDT 2024


MaskRay wrote:

I believe the intention was:

> Before the patch:
> "stk_begin, tls_begin, stk_end, tls_end": range [stk_end, tls_end) was discarded.

However, the case is invalid and impossible. If `stk_begin<tls_begin<stk_end`, the tls range must be a subrange of [stk_begin,stk_end).


> After the patch:
> "stk_begin, tls_begin, stk_end, tls_end": range [stk_end, tls_end) goes to tls.

I think this is a no-op.

> "stk_begin, tls_begin, tls_end, stk_end": range [stk_end, stk_end) goes to tls.

This extension effect isn't needed.

---

I think we can remove this statement.


https://github.com/llvm/llvm-project/pull/108672


More information about the llvm-commits mailing list