[llvm] [CMake][Support] Suppress ml64 assembler logo printing when compiling BLAKE3 on Windows (PR #106794)
Matt Bolitho via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 30 14:52:14 PDT 2024
================
@@ -28,12 +28,18 @@ if (CAN_USE_ASSEMBLER)
check_symbol_exists(_M_X64 "" IS_X64)
if (IS_X64)
enable_language(ASM_MASM)
- list(APPEND LLVM_BLAKE3_FILES
+ set(LLVM_BLAKE3_ASM_FILES
blake3_sse2_x86-64_windows_msvc.asm
blake3_sse41_x86-64_windows_msvc.asm
blake3_avx2_x86-64_windows_msvc.asm
blake3_avx512_x86-64_windows_msvc.asm
)
+ list(APPEND LLVM_BLAKE3_FILES ${LLVM_BLAKE3_ASM_FILES})
+ # Supress the copyright message and 'Assembling...' message.
+ foreach(LLVM_BLAKE3_ASM_FILE ${LLVM_BLAKE3_ASM_FILES})
+ set_source_files_properties(${LLVM_BLAKE3_ASM_FILE}
+ PROPERTIES COMPILE_OPTIONS "/quiet;/nologo")
----------------
MattBolitho wrote:
Thanks for the explanation. Even with just `/nologo` the improvement is much better imo.
I don't think the generic `check_compiler_flag` function supports `ASM_MASM` so the logic _might_ get a bit involved for a small win (unless there are other places that would benefit). I am happy to use only `/nologo` based on that.
https://github.com/llvm/llvm-project/pull/106794
More information about the llvm-commits
mailing list