[lld] [LTO][ELF][lld] Use unique string saver in ELF bitcode symbol parsing (PR #106670)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 30 12:14:37 PDT 2024
================
@@ -335,6 +339,12 @@ class BitcodeFile : public InputFile {
void postParse();
std::unique_ptr<llvm::lto::InputFile> obj;
std::vector<bool> keptComdats;
+
+private:
+ StringRef saved_symbol(const char *S);
----------------
kazutakahirata wrote:
I realize Teresa has already suggested you to use `unique_saver().save()` directly. Even if you keep these `saved_symbol`, the one that takes `cons char *` should be redundant because we can `StringRef` has an implicit constructor from `const char *`.
The same applies to the one below that takes `const std::string &`.
https://github.com/llvm/llvm-project/pull/106670
More information about the llvm-commits
mailing list