[llvm] Revert "[llvm-lit] Add precommit test to verify current behavior of glob expansion in lit's internal shell" (PR #106763)

via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 30 10:09:39 PDT 2024


https://github.com/Harini0924 created https://github.com/llvm/llvm-project/pull/106763

Reverts llvm/llvm-project#106325
Broke some Buildbots. 

>From 3f438c3e7f40f09118d4e1fa8a81b596f3ada5d1 Mon Sep 17 00:00:00 2001
From: Harini0924 <harinidonthula at gmail.com>
Date: Fri, 30 Aug 2024 10:05:09 -0700
Subject: [PATCH] =?UTF-8?q?Revert=20"[llvm-lit]=20Add=20precommit=20test?=
 =?UTF-8?q?=20to=20verify=20current=20behavior=20of=20glob=20expa=E2=80=A6?=
 =?UTF-8?q?"?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This reverts commit 9764cf888502fe6dd15ab21de5c2f73cae47a2c0.
---
 .../lit/tests/Inputs/shtest-glob/example_file1.input |  2 --
 .../lit/tests/Inputs/shtest-glob/example_file2.input |  2 --
 .../utils/lit/tests/Inputs/shtest-glob/glob-echo.txt |  2 --
 .../lit/tests/Inputs/shtest-glob/glob-mkdir.txt      |  2 --
 llvm/utils/lit/tests/Inputs/shtest-glob/lit.cfg      |  8 --------
 llvm/utils/lit/tests/shtest-glob.py                  | 12 ------------
 6 files changed, 28 deletions(-)
 delete mode 100644 llvm/utils/lit/tests/Inputs/shtest-glob/example_file1.input
 delete mode 100644 llvm/utils/lit/tests/Inputs/shtest-glob/example_file2.input
 delete mode 100644 llvm/utils/lit/tests/Inputs/shtest-glob/glob-echo.txt
 delete mode 100644 llvm/utils/lit/tests/Inputs/shtest-glob/glob-mkdir.txt
 delete mode 100644 llvm/utils/lit/tests/Inputs/shtest-glob/lit.cfg
 delete mode 100644 llvm/utils/lit/tests/shtest-glob.py

diff --git a/llvm/utils/lit/tests/Inputs/shtest-glob/example_file1.input b/llvm/utils/lit/tests/Inputs/shtest-glob/example_file1.input
deleted file mode 100644
index 0987c9081ca1f3..00000000000000
--- a/llvm/utils/lit/tests/Inputs/shtest-glob/example_file1.input
+++ /dev/null
@@ -1,2 +0,0 @@
-## This is the first example file used for testing glob pattern matching.
-This is the first example file.
diff --git a/llvm/utils/lit/tests/Inputs/shtest-glob/example_file2.input b/llvm/utils/lit/tests/Inputs/shtest-glob/example_file2.input
deleted file mode 100644
index f1a843f308262e..00000000000000
--- a/llvm/utils/lit/tests/Inputs/shtest-glob/example_file2.input
+++ /dev/null
@@ -1,2 +0,0 @@
-## This is the second example file used for testing glob pattern matching.
-This is the second example file.
diff --git a/llvm/utils/lit/tests/Inputs/shtest-glob/glob-echo.txt b/llvm/utils/lit/tests/Inputs/shtest-glob/glob-echo.txt
deleted file mode 100644
index b69f5e74fd7281..00000000000000
--- a/llvm/utils/lit/tests/Inputs/shtest-glob/glob-echo.txt
+++ /dev/null
@@ -1,2 +0,0 @@
-## Tests glob pattern expansion by listing matching files.
-# RUN: echo %S/example_file*.input
diff --git a/llvm/utils/lit/tests/Inputs/shtest-glob/glob-mkdir.txt b/llvm/utils/lit/tests/Inputs/shtest-glob/glob-mkdir.txt
deleted file mode 100644
index d1329f5dbfaaed..00000000000000
--- a/llvm/utils/lit/tests/Inputs/shtest-glob/glob-mkdir.txt
+++ /dev/null
@@ -1,2 +0,0 @@
-## Tests glob pattern handling in the mkdir command.
-# RUN: not mkdir %S/example_file*.input
diff --git a/llvm/utils/lit/tests/Inputs/shtest-glob/lit.cfg b/llvm/utils/lit/tests/Inputs/shtest-glob/lit.cfg
deleted file mode 100644
index 4e5f4cac4c4653..00000000000000
--- a/llvm/utils/lit/tests/Inputs/shtest-glob/lit.cfg
+++ /dev/null
@@ -1,8 +0,0 @@
-import lit.formats
-
-config.name = "shtest-glob"
-config.suffixes = [".txt"]
-config.test_format = lit.formats.ShTest()
-config.test_source_root = None
-config.test_exec_root = None
-config.substitutions.append(("%{python}", '"%s"' % (sys.executable)))
diff --git a/llvm/utils/lit/tests/shtest-glob.py b/llvm/utils/lit/tests/shtest-glob.py
deleted file mode 100644
index 551331cb38e259..00000000000000
--- a/llvm/utils/lit/tests/shtest-glob.py
+++ /dev/null
@@ -1,12 +0,0 @@
-## Tests glob pattern handling in echo command.
-
-# RUN: not %{lit} -a -v %{inputs}/shtest-glob \
-# RUN: | FileCheck -dump-input=fail -match-full-lines %s
-#
-# END.
-
-# CHECK: UNRESOLVED: shtest-glob :: glob-echo.txt ({{[^)]*}})
-# CHECK: TypeError: string argument expected, got 'GlobItem'
-
-# CHECK: FAIL: shtest-glob :: glob-mkdir.txt ({{[^)]*}}
-# CHECK: # error: command failed with exit status: 1



More information about the llvm-commits mailing list