[llvm] [llvm-lit] Add precommit test to verify current behavior of glob expansion in lit's internal shell (PR #106325)

Fri Aug 30 09:50:09 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while building `llvm` at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/5871

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'lit :: shtest-glob.py' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 3
not env -u FILECHECK_OPTS "/usr/bin/python3.10" /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/utils/lit/lit.py -j1 --order=lexical -a -v Inputs/shtest-glob  | FileCheck -dump-input=fail -match-full-lines /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/utils/lit/tests/shtest-glob.py
# executed command: not env -u FILECHECK_OPTS /usr/bin/python3.10 /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/utils/lit/lit.py -j1 --order=lexical -a -v Inputs/shtest-glob
# executed command: FileCheck -dump-input=fail -match-full-lines /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/utils/lit/tests/shtest-glob.py
# .---command stderr------------
# | [1m/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/utils/lit/tests/shtest-glob.py:11:10: [0m[0;1;31merror: [0m[1mCHECK: expected string not found in input
# | [0m# CHECK: FAIL: shtest-glob :: glob-mkdir.txt ({{[^)]*}}
# | [0;1;32m         ^
# | [0m[1m<stdin>:26:52: [0m[0;1;30mnote: [0m[1mscanning from here
# | [0mTypeError: string argument expected, got 'GlobItem'
# | [0;1;32m                                                   ^
# | [0m[1m<stdin>:30:1: [0m[0;1;30mnote: [0m[1mpossible intended match here
# | [0mFAIL: shtest-glob :: glob-mkdir.txt (2 of 2)
# | [0;1;32m^
# | [0m
# | Input file: <stdin>
# | Check file: /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/utils/lit/tests/shtest-glob.py
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# | [1m[0m[0;1;30m            1: [0m[1m[0;1;46m-- Testing: 2 tests, 1 workers -- [0m
# | [0;1;30m            2: [0m[1m[0;1;46m[0mUNRESOLVED: shtest-glob :: glob-echo.txt (1 of 2)[0;1;46m [0m
# | [0;1;32mcheck:8        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | [0m[0;1;30m            3: [0m[1m[0;1;46m******************** TEST 'shtest-glob :: glob-echo.txt' FAILED ******************** [0m
# | [0;1;30m            4: [0m[1m[0;1;46mException during script execution: [0m
# | [0;1;30m            5: [0m[1m[0;1;46mTraceback (most recent call last): [0m
# | [0;1;30m            6: [0m[1m[0;1;46m File "/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/utils/lit/lit/worker.py", line 76, in _execute_test_handle_errors [0m
# | [0;1;30m            7: [0m[1m[0;1;46m result = test.config.test_format.execute(test, lit_config) [0m
# | [0;1;30m            8: [0m[1m[0;1;46m File "/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/utils/lit/lit/formats/shtest.py", line 29, in execute [0m
# | [0;1;30m            9: [0m[1m[0;1;46m return lit.TestRunner.executeShTest( [0m
# | [0;1;30m           10: [0m[1m[0;1;46m File "/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/utils/lit/lit/TestRunner.py", line 2298, in executeShTest [0m
# | [0;1;30m           11: [0m[1m[0;1;46m return _runShTest(test, litConfig, useExternalSh, script, tmpBase) [0m
# | [0;1;30m           12: [0m[1m[0;1;46m File "/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/utils/lit/lit/TestRunner.py", line 2242, in _runShTest [0m
# | [0;1;30m           13: [0m[1m[0;1;46m res = runOnce(execdir) [0m
# | [0;1;30m           14: [0m[1m[0;1;46m File "/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/utils/lit/lit/TestRunner.py", line 2218, in runOnce [0m
# | [0;1;30m           15: [0m[1m[0;1;46m res = executeScriptInternal( [0m
# | [0;1;30m           16: [0m[1m[0;1;46m File "/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/utils/lit/lit/TestRunner.py", line 1086, in executeScriptInternal [0m
# | [0;1;30m           17: [0m[1m[0;1;46m exitCode, timeoutInfo = executeShCmd( [0m
# | [0;1;30m           18: [0m[1m[0;1;46m File "/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/utils/lit/lit/TestRunner.py", line 204, in executeShCmd [0m
# | [0;1;30m           19: [0m[1m[0;1;46m finalExitCode = _executeShCmd(cmd, shenv, results, timeoutHelper) [0m
# | [0;1;30m           20: [0m[1m[0;1;46m File "/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/utils/lit/lit/TestRunner.py", line 696, in _executeShCmd [0m
# | [0;1;30m           21: [0m[1m[0;1;46m res = _executeShCmd(cmd.rhs, shenv, results, timeoutHelper) [0m
# | [0;1;30m           22: [0m[1m[0;1;46m File "/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/utils/lit/lit/TestRunner.py", line 799, in _executeShCmd [0m
...

```

</details>

https://github.com/llvm/llvm-project/pull/106325