[llvm] [SLP][NFC] Remove useless code of deleting ExtractElementInst (PR #106697)

via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 30 08:56:09 PDT 2024


tcwzxx wrote:

> removeInstructionsAndOperands is called only for the scalars, which are part of the vectorized nodes.

Yes. But also for the operators of scalars. (**_EI must be a operator of those scalar_**)
My point is that `removeInstructionsAndOperands` can do everything `adjustExtracts` does in terms of erasing `EI`.

> Gathered nodes processed separately. 

Gathered nodes is in the middle of vectoriztion process. It's information is not enough.

> You mean the extractelement can be included in the list of the vectorized nodes?

No, i don't think so.





https://github.com/llvm/llvm-project/pull/106697


More information about the llvm-commits mailing list