[llvm] [DirectX] add enum for PSV resource type/kind/flag. (PR #106227)

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 11:42:44 PDT 2024


================
@@ -70,18 +70,18 @@ Parts:
 # CHECK-NEXT: NumThreadsZ:     2048
 # CHECK-NEXT: ResourceStride: 24
 # CHECK-NEXT: Resources:
-# CHECK-NEXT: - Type:            1
+# CHECK-NEXT: - Type:            Sampler
 # CHECK-NEXT: Space:           2
 # CHECK-NEXT: LowerBound:      3
 # CHECK-NEXT: UpperBound:      4
-# CHECK-NEXT: Kind:            5
-# CHECK-NEXT: Flags:           6
-# CHECK-NEXT: - Type:            128
+# CHECK-NEXT: Kind:            TextureCube
+# CHECK-NEXT: Flags:           0
+# CHECK-NEXT: - Type:            Invalid
----------------
bogner wrote:

Oh I see. We don't actually use the ResourceFlag enum in this change at all, so `LLVM_YAML_DECLARE_ENUM_TRAITS(llvm::dxbc::PSV::ResourceFlag)` and `ScalarEnumerationTraits<dxbc::PSV::ResourceFlag>::enumeration` are just entirely dead code.

https://github.com/llvm/llvm-project/pull/106227


More information about the llvm-commits mailing list