[llvm] [DebugInfo][RemoveDIs] Find types hidden in DbgRecords (PR #106547)

Orlando Cazalet-Hyams via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 06:48:30 PDT 2024


https://github.com/OCHyams approved this pull request.

> We'll want an iterator in the future that does this for us (give us all the values in some DbgRecord), but not today.

+1
I think DbgRecords currently reflect the (also poor) interface we use in intrinsics, but it's probably it's more painful for records because a number of sites that would iterate over intrinsic arguments (and thus find all values) now need to do the kind of thing you've done here.

LGTM. @nikic do you have any further comments?

https://github.com/llvm/llvm-project/pull/106547


More information about the llvm-commits mailing list