[llvm] y (PR #106543)

via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 04:57:43 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-analysis

Author: Thomas Preud'homme (RoboTux)

<details>
<summary>Changes</summary>

LLVM has a CMake variable to control whether to consider logf128
constant folding which libAnalysis ignores. This patch changes the
logf128 check to rely on the global LLVM_HAS_LOGF128 setting made in
config-ix.cmake.


---
Full diff: https://github.com/llvm/llvm-project/pull/106543.diff


1 Files Affected:

- (modified) llvm/lib/Analysis/CMakeLists.txt (+2-4) 


``````````diff
diff --git a/llvm/lib/Analysis/CMakeLists.txt b/llvm/lib/Analysis/CMakeLists.txt
index 393803fad89383..99ce0acdabe1ba 100644
--- a/llvm/lib/Analysis/CMakeLists.txt
+++ b/llvm/lib/Analysis/CMakeLists.txt
@@ -163,8 +163,6 @@ add_llvm_component_library(LLVMAnalysis
   TargetParser
   )
 
-include(CheckCXXSymbolExists)
-check_cxx_symbol_exists(logf128 math.h HAS_LOGF128)
-if(HAS_LOGF128)
- target_compile_definitions(LLVMAnalysis PRIVATE HAS_LOGF128)
+if(LLVM_HAS_LOGF128)
+  target_compile_definitions(LLVMAnalysis PRIVATE HAS_LOGF128)
 endif()

``````````

</details>


https://github.com/llvm/llvm-project/pull/106543


More information about the llvm-commits mailing list