[llvm] 606a934 - [LAA] Add test cases where evaluating AddRecs at symbolic max BTC wraps.
Florian Hahn via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 29 04:29:28 PDT 2024
Author: Florian Hahn
Date: 2024-08-29T12:29:10+01:00
New Revision: 606a9342f1083eef1475c2a97eabb04db9338bdd
URL: https://github.com/llvm/llvm-project/commit/606a9342f1083eef1475c2a97eabb04db9338bdd
DIFF: https://github.com/llvm/llvm-project/commit/606a9342f1083eef1475c2a97eabb04db9338bdd.diff
LOG: [LAA] Add test cases where evaluating AddRecs at symbolic max BTC wraps.
The underlying issue was discovered by an assert added in
a80053322b765eec939 by a test case provided by @mstorsjo.
Added:
llvm/test/Analysis/LoopAccessAnalysis/evaluate-at-symbolic-max-backedge-taken-count-may-wrap.ll
Modified:
Removed:
################################################################################
diff --git a/llvm/test/Analysis/LoopAccessAnalysis/evaluate-at-symbolic-max-backedge-taken-count-may-wrap.ll b/llvm/test/Analysis/LoopAccessAnalysis/evaluate-at-symbolic-max-backedge-taken-count-may-wrap.ll
new file mode 100644
index 00000000000000..b9951c7ed02ec0
--- /dev/null
+++ b/llvm/test/Analysis/LoopAccessAnalysis/evaluate-at-symbolic-max-backedge-taken-count-may-wrap.ll
@@ -0,0 +1,139 @@
+; NOTE: Assertions have been autogenerated by utils/update_analyze_test_checks.py UTC_ARGS: --version 5
+; RUN: opt -passes='print<access-info>' -disable-output %s 2>&1 | FileCheck %s
+
+target datalayout = "e-m:e-p:32:32-Fi8-i64:64-v128:64:128-a:0:32-n32-S64"
+
+; FIXME: Start == End for access group with AddRec.
+define void @runtime_checks_with_symbolic_max_btc_neg_1(ptr %P, ptr %S, i32 %x, i32 %y) {
+; CHECK-LABEL: 'runtime_checks_with_symbolic_max_btc_neg_1'
+; CHECK-NEXT: loop:
+; CHECK-NEXT: Memory dependences are safe with run-time checks
+; CHECK-NEXT: Dependences:
+; CHECK-NEXT: Run-time memory checks:
+; CHECK-NEXT: Check 0:
+; CHECK-NEXT: Comparing group ([[GRP1:0x[0-9a-f]+]]):
+; CHECK-NEXT: %gep.iv = getelementptr inbounds i32, ptr %P, i32 %iv
+; CHECK-NEXT: Against group ([[GRP2:0x[0-9a-f]+]]):
+; CHECK-NEXT: ptr %S
+; CHECK-NEXT: Grouped accesses:
+; CHECK-NEXT: Group [[GRP1]]:
+; CHECK-NEXT: (Low: ((4 * %y) + %P) High: ((4 * %y) + %P))
+; CHECK-NEXT: Member: {((4 * %y) + %P),+,4}<%loop>
+; CHECK-NEXT: Group [[GRP2]]:
+; CHECK-NEXT: (Low: %S High: (4 + %S))
+; CHECK-NEXT: Member: %S
+; CHECK-EMPTY:
+; CHECK-NEXT: Non vectorizable stores to invariant address were not found in loop.
+; CHECK-NEXT: SCEV assumptions:
+; CHECK-EMPTY:
+; CHECK-NEXT: Expressions re-written:
+;
+entry:
+ br label %loop
+
+loop:
+ %iv = phi i32 [ %y, %entry ], [ %iv.next, %loop ]
+ %gep.iv = getelementptr inbounds i32, ptr %P, i32 %iv
+ %l = load i32, ptr %S
+ store i32 %l, ptr %gep.iv, align 4
+ %iv.next = add nsw i32 %iv, 1
+ %c.2 = icmp slt i32 %iv.next, %l
+ br i1 %c.2, label %loop, label %exit
+
+exit:
+ ret void
+}
+
+; FIXME: Start > End for access group with AddRec.
+define void @runtime_check_with_symbolic_max_btc_neg_2(ptr %P, ptr %S, i32 %x, i32 %y) {
+; CHECK-LABEL: 'runtime_check_with_symbolic_max_btc_neg_2'
+; CHECK-NEXT: loop:
+; CHECK-NEXT: Memory dependences are safe with run-time checks
+; CHECK-NEXT: Dependences:
+; CHECK-NEXT: Run-time memory checks:
+; CHECK-NEXT: Check 0:
+; CHECK-NEXT: Comparing group ([[GRP3:0x[0-9a-f]+]]):
+; CHECK-NEXT: %gep.iv = getelementptr inbounds i32, ptr %P, i32 %iv
+; CHECK-NEXT: Against group ([[GRP4:0x[0-9a-f]+]]):
+; CHECK-NEXT: ptr %S
+; CHECK-NEXT: Grouped accesses:
+; CHECK-NEXT: Group [[GRP3]]:
+; CHECK-NEXT: (Low: ((4 * %y) + %P) High: (-4 + (4 * %y) + %P))
+; CHECK-NEXT: Member: {((4 * %y) + %P),+,4}<%loop>
+; CHECK-NEXT: Group [[GRP4]]:
+; CHECK-NEXT: (Low: %S High: (4 + %S))
+; CHECK-NEXT: Member: %S
+; CHECK-EMPTY:
+; CHECK-NEXT: Non vectorizable stores to invariant address were not found in loop.
+; CHECK-NEXT: SCEV assumptions:
+; CHECK-EMPTY:
+; CHECK-NEXT: Expressions re-written:
+;
+entry:
+ br label %loop
+
+loop:
+ %iv = phi i32 [ %y, %entry ], [ %iv.next, %loop ]
+ %gep.iv = getelementptr inbounds i32, ptr %P, i32 %iv
+ %l = load i32, ptr %S
+ store i32 %l, ptr %gep.iv, align 4
+ %iv.next = add nsw i32 %iv, 1
+ %a = and i32 %l, -2
+ %c.2 = icmp slt i32 %iv.next, %a
+ br i1 %c.2, label %loop, label %exit
+
+exit:
+ ret void
+}
+
+define i32 @check_no_dep_via_bounds_compare_symbolic_max_btc_neg_1(ptr %P, i32 %x, i32 %y) {
+; CHECK-LABEL: 'check_no_dep_via_bounds_compare_symbolic_max_btc_neg_1'
+; CHECK-NEXT: loop:
+; CHECK-NEXT: Report: unsafe dependent memory operations in loop. Use #pragma clang loop distribute(enable) to allow loop distribution to attempt to isolate the offending operations into a separate loop
+; CHECK-NEXT: Unknown data dependence.
+; CHECK-NEXT: Dependences:
+; CHECK-NEXT: Unknown:
+; CHECK-NEXT: store i64 0, ptr %gep.iv, align 4 ->
+; CHECK-NEXT: %l.2 = load i32, ptr %gep.P.4, align 4
+; CHECK-EMPTY:
+; CHECK-NEXT: Unknown:
+; CHECK-NEXT: %l = load i32, ptr %gep.iv, align 4 ->
+; CHECK-NEXT: store i64 0, ptr %gep.iv, align 4
+; CHECK-EMPTY:
+; CHECK-NEXT: Run-time memory checks:
+; CHECK-NEXT: Grouped accesses:
+; CHECK-EMPTY:
+; CHECK-NEXT: Non vectorizable stores to invariant address were not found in loop.
+; CHECK-NEXT: SCEV assumptions:
+; CHECK-NEXT: {(8 + (8 * %y) + %P),+,8}<%loop> Added Flags: <nusw>
+; CHECK-EMPTY:
+; CHECK-NEXT: Expressions re-written:
+;
+entry:
+ %gep.P.4 = getelementptr inbounds nuw i8, ptr %P, i32 4
+ %gep.P.8 = getelementptr inbounds nuw i8, ptr %P, i32 8
+ br label %loop
+
+loop:
+ %1 = phi i32 [ %x, %entry ], [ %sel, %loop.latch ]
+ %iv = phi i32 [ %y, %entry ], [ %iv.next, %loop.latch ]
+ %gep.iv = getelementptr inbounds i64, ptr %gep.P.8, i32 %iv
+ %l = load i32, ptr %gep.iv, align 4
+ %c.1 = icmp eq i32 %l, 3
+ br i1 %c.1, label %loop.latch, label %if.then
+
+if.then: ; preds = %for.body
+ store i64 0, ptr %gep.iv, align 4
+ %l.2 = load i32, ptr %gep.P.4
+ br label %loop.latch
+
+loop.latch:
+ %sel = phi i32 [ %l.2, %if.then ], [ %1, %loop ]
+ %iv.next = add nsw i32 %iv, 1
+ %c.2 = icmp slt i32 %iv.next, %sel
+ br i1 %c.2, label %loop, label %exit
+
+exit:
+ %res = phi i32 [ %iv.next, %loop.latch ]
+ ret i32 %res
+}
More information about the llvm-commits
mailing list