[lld] [LLD] Improve linker script handing in LLD (PR #106334)

Daniel Thornburgh via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 11:13:48 PDT 2024


================
@@ -131,6 +131,156 @@ uint64_t ExprValue::getSectionOffset() const {
   return getValue() - getSecAddr();
 }
 
+std::function<ExprValue()> ScriptExpr::getExpr() const {
+  switch (kind_) {
+  case ExprKind::Constant:
+    return static_cast<const ConstantExpr *>(this)->getConstantExpr();
+  case ExprKind::Dynamic: {
----------------
mysterymath wrote:

Having second thoughts about the name "Dynamic"; that word implies change or motion, which doesn't actually seem to fit here, since the logic doesn't actually change. It's a variable, not a time series. Maybe "Generic"? "Functor"?

https://github.com/llvm/llvm-project/pull/106334


More information about the llvm-commits mailing list