[llvm] b1d1c33 - [lit] Remove legacy python version checks (NFC) (#105948)

via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 27 21:30:20 PDT 2024


Author: Keith Smiley
Date: 2024-08-27T21:30:18-07:00
New Revision: b1d1c33ad1c922911a454a428cc145353376b894

URL: https://github.com/llvm/llvm-project/commit/b1d1c33ad1c922911a454a428cc145353376b894
DIFF: https://github.com/llvm/llvm-project/commit/b1d1c33ad1c922911a454a428cc145353376b894.diff

LOG: [lit] Remove legacy python version checks (NFC) (#105948)

Added: 
    

Modified: 
    llvm/utils/lit/lit/TestRunner.py
    llvm/utils/lit/lit/llvm/config.py

Removed: 
    


################################################################################
diff  --git a/llvm/utils/lit/lit/TestRunner.py b/llvm/utils/lit/lit/TestRunner.py
index e3ca9b1fb32cc7..b85c3ca3f6309e 100644
--- a/llvm/utils/lit/lit/TestRunner.py
+++ b/llvm/utils/lit/lit/TestRunner.py
@@ -406,8 +406,7 @@ def maybeUnescape(arg):
             return arg
 
         arg = lit.util.to_bytes(arg)
-        codec = "string_escape" if sys.version_info < (3, 0) else "unicode_escape"
-        return arg.decode(codec)
+        return arg.decode("unicode_escape")
 
     if args:
         for arg in args[:-1]:
@@ -1173,7 +1172,7 @@ def executeScript(test, litConfig, tmpBase, commands, cwd):
     open_kwargs = {}
     if litConfig.isWindows and not isWin32CMDEXE:
         mode += "b"  # Avoid CRLFs when writing bash scripts.
-    elif sys.version_info > (3, 0):
+    else:
         open_kwargs["encoding"] = "utf-8"
     f = open(script, mode, **open_kwargs)
     if isWin32CMDEXE:
@@ -1237,7 +1236,7 @@ def executeScript(test, litConfig, tmpBase, commands, cwd):
         )
         f.write(bytes(env_str, "utf-8") if mode == "wb" else env_str)
         f.write(b"set -x;" if mode == "wb" else "set -x;")
-        if sys.version_info > (3, 0) and mode == "wb":
+        if mode == "wb":
             f.write(bytes("{ " + "; } &&\n{ ".join(commands) + "; }", "utf-8"))
         else:
             f.write("{ " + "; } &&\n{ ".join(commands) + "; }")

diff  --git a/llvm/utils/lit/lit/llvm/config.py b/llvm/utils/lit/lit/llvm/config.py
index b3dfddba483f53..8a6a0c2ed8089e 100644
--- a/llvm/utils/lit/lit/llvm/config.py
+++ b/llvm/utils/lit/lit/llvm/config.py
@@ -186,10 +186,7 @@ def __init__(self, lit_config, config):
 
     def _find_git_windows_unix_tools(self, tools_needed):
         assert sys.platform == "win32"
-        if sys.version_info.major >= 3:
-            import winreg
-        else:
-            import _winreg as winreg
+        import winreg
 
         # Search both the 64 and 32-bit hives, as well as HKLM + HKCU
         masks = [0, winreg.KEY_WOW64_64KEY]


        


More information about the llvm-commits mailing list