[llvm] [ctx_prof] Add support for ICP (PR #105469)

Tue Aug 27 15:57:44 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-nvptx-nvidia-ubuntu` running on `as-builder-7` while building `llvm` at step 6 "test-build-unified-tree-check-llvm".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/180/builds/4050

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test-build-unified-tree-check-llvm) failure: test (failure)
...
11.278 [10/14/637] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/FunctionPropertiesAnalysisTest.cpp.o
11.501 [10/13/638] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/MachineDomTreeUpdaterTest.cpp.o
11.606 [9/13/639] Building CXX object unittests/IR/CMakeFiles/IRTests.dir/IRBuilderTest.cpp.o
11.678 [9/12/640] Building CXX object unittests/IR/CMakeFiles/IRTests.dir/VPIntrinsicTest.cpp.o
11.777 [9/11/641] Linking CXX executable unittests/CodeGen/CodeGenTests
11.972 [9/10/642] Building CXX object unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/CloningTest.cpp.o
11.974 [8/10/643] Building CXX object unittests/Passes/Plugins/CMakeFiles/PluginsTests.dir/PluginsTest.cpp.o
12.008 [7/10/644] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/CtxProfAnalysisTest.cpp.o
12.057 [6/10/645] Linking CXX executable unittests/Passes/Plugins/PluginsTests
12.137 [6/9/646] Linking CXX executable unittests/Transforms/Utils/UtilsTests
FAILED: unittests/Transforms/Utils/UtilsTests 
: && /usr/bin/c++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -fuse-ld=gold     -Wl,--gc-sections unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/ASanStackFrameLayoutTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/BasicBlockUtilsTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/CallPromotionUtilsTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/CloningTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/CodeExtractorTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/CodeLayoutTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/CodeMoverUtilsTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/DebugifyTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/FunctionComparatorTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/IntegerDivisionTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/LocalTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/LoopRotationUtilsTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/LoopUtilsTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/MemTransferLowering.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/ModuleUtilsTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/ScalarEvolutionExpanderTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/SizeOptsTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/SSAUpdaterBulkTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/UnrollLoopTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/ValueMapperTest.cpp.o unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/ProfDataUtilTest.cpp.o -o unittests/Transforms/Utils/UtilsTests  -Wl,-rpath,/home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/build/lib  lib/libLLVMPasses.so.20.0git  lib/libllvm_gtest_main.so.20.0git  lib/libllvm_gtest.so.20.0git  lib/libLLVMBitWriter.so.20.0git  lib/libLLVMVectorize.so.20.0git  lib/libLLVMTransformUtils.so.20.0git  lib/libLLVMAnalysis.so.20.0git  lib/libLLVMAsmParser.so.20.0git  lib/libLLVMCore.so.20.0git  lib/libLLVMSupport.so.20.0git  -Wl,-rpath-link,/home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/build/lib && :
unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/CallPromotionUtilsTest.cpp.o:CallPromotionUtilsTest.cpp:function CallPromotionUtilsTest_PromoteWithIcmpAndCtxProf_Test::TestBody() [clone .localalias]: error: undefined reference to 'llvm::createCtxProfFromJSON(llvm::StringRef, llvm::raw_ostream&)'
collect2: error: ld returned 1 exit status
12.358 [6/8/647] Linking CXX executable unittests/Analysis/AnalysisTests
12.572 [6/7/648] Building CXX object unittests/Transforms/Instrumentation/CMakeFiles/InstrumentationTests.dir/PGOInstrumentationTest.cpp.o
14.502 [6/6/649] Building CXX object unittests/IR/CMakeFiles/IRTests.dir/PatternMatch.cpp.o
/home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/unittests/IR/PatternMatch.cpp: In lambda function:
/home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/unittests/IR/PatternMatch.cpp:640:8: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else]
  640 |     if (CheckUgt1(APVal))
      |        ^
/home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/unittests/IR/PatternMatch.cpp:646:8: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else]
  646 |     if (CheckNonZero(APVal))
      |        ^
/home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/unittests/IR/PatternMatch.cpp:652:8: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else]
  652 |     if (CheckPow2(APVal))
      |        ^
/home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/unittests/IR/PatternMatch.cpp: In lambda function:
/home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/unittests/IR/PatternMatch.cpp:713:10: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else]
  713 |       if (AllSame)
      |          ^
14.554 [6/5/650] Building CXX object unittests/Transforms/Vectorize/CMakeFiles/VectorizeTests.dir/VPlanTest.cpp.o
19.046 [6/4/651] Building CXX object unittests/IR/CMakeFiles/IRTests.dir/MetadataTest.cpp.o
In file included from /home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/unittests/IR/MetadataTest.cpp:9:
In member function ‘void llvm::ContextAndReplaceableUses::makeReplaceable(std::unique_ptr<llvm::ReplaceableMetadataImpl>)’,
    inlined from ‘virtual void {anonymous}::ContextAndReplaceableUsesTest_makeReplaceable_Test::TestBody()’ at /home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/unittests/IR/MetadataTest.cpp:49:22:
/home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/include/llvm/IR/Metadata.h:1021:31: warning: ‘void operator delete(void*, std::size_t)’ called on unallocated object ‘Context’ [-Wfree-nonheap-object]
 1021 |     delete getReplaceableUses();
      |                               ^
/home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/unittests/IR/MetadataTest.cpp: In member function ‘virtual void {anonymous}::ContextAndReplaceableUsesTest_makeReplaceable_Test::TestBody()’:
/home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/unittests/IR/MetadataTest.cpp:47:15: note: declared here
   47 |   LLVMContext Context;
      |               ^~~~~~~
22.805 [6/3/652] Building CXX object unittests/Transforms/Scalar/CMakeFiles/ScalarTests.dir/LoopPassManagerTest.cpp.o
26.337 [6/2/653] Building CXX object unittests/IR/CMakeFiles/IRTests.dir/PassBuilderCallbacksTest.cpp.o
28.629 [6/1/654] Building CXX object unittests/Frontend/CMakeFiles/LLVMFrontendTests.dir/OpenMPIRBuilderTest.cpp.o
/home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp: In member function ‘virtual void {anonymous}::OpenMPIRBuilderTest_CriticalDirective_Test::TestBody()’:
/home/buildbot/worker/as-builder-7/ramdisk/llvm-nvptx-nvidia-ubuntu/llvm-project/llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:2940:6: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else]
 2940 |   if (const llvm::MaybeAlign Alignment = GV->getAlign())

```

</details>

https://github.com/llvm/llvm-project/pull/105469