[llvm] [AArch64] Lower partial add reduction to udot or svdot (PR #101010)
Paul Walker via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 27 10:41:27 PDT 2024
================
@@ -1590,6 +1590,11 @@ class SelectionDAG {
/// the target's desired shift amount type.
SDValue getShiftAmountOperand(EVT LHSTy, SDValue Op);
+ /// Expand a partial reduction intrinsic call.
+ /// Op1 and Op2 are its operands and ReducedTY is the intrinsic's return type.
+ SDValue expandPartialReductionIntrinsic(EVT ReducedTy, SDValue Op1,
----------------
paulwalker-arm wrote:
The name lacks sufficient context (i.e. the "add" part is very important) but at the same time this nicely abstracts the intrinsic side of things so perhaps "getPartialReduceAdd()" is more representative?
On similar lines what do you think to mirroring the operand order of similar `getNode()` calls? (i.e. DL, VT, operands....)
https://github.com/llvm/llvm-project/pull/101010
More information about the llvm-commits
mailing list