[llvm] [SCCP] get rid of potentially dangling iterator (PR #105609)

[Alexandros Lamprineas via llvm-commits]

labrinea wrote:

Hi. I am not seeing a modification of KnownConstants between the point where the iterator is initialized and the point it is consumed. Am I missing something?

https://github.com/llvm/llvm-project/pull/105609