[compiler-rt] d28c0fb - [compiler-rt][tests] Removed the use of parentheses in compiler-rt tests with lit internal shell (#105729)

via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 26 20:34:11 PDT 2024


Author: Harini0924
Date: 2024-08-26T20:34:05-07:00
New Revision: d28c0fb186dad157daf00a8a43a34daa49593cda

URL: https://github.com/llvm/llvm-project/commit/d28c0fb186dad157daf00a8a43a34daa49593cda
DIFF: https://github.com/llvm/llvm-project/commit/d28c0fb186dad157daf00a8a43a34daa49593cda.diff

LOG: [compiler-rt][tests] Removed the use of parentheses in compiler-rt tests with lit internal shell (#105729)

This patch addresses compatibility issues with the lit internal shell by
removing the use of subshell execution (parentheses and subshell syntax)
in the `merge-posix.test` and `vptr.cpp` tests. The lit internal shell
does not support parentheses, so the tests have been refactored to use
separate command invocations.

This change is relevant for enabling the lit internal shell by default,
as outlined in [[RFC] Enabling the Lit Internal Shell by
Default](https://discourse.llvm.org/t/rfc-enabling-the-lit-internal-shell-by-default/80179)

fixes: #102401

Added: 
    

Modified: 
    compiler-rt/test/ubsan/TestCases/TypeCheck/vptr.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/ubsan/TestCases/TypeCheck/vptr.cpp b/compiler-rt/test/ubsan/TestCases/TypeCheck/vptr.cpp
index 2d0e48cd84f3cf..4f2a5e65005edf 100644
--- a/compiler-rt/test/ubsan/TestCases/TypeCheck/vptr.cpp
+++ b/compiler-rt/test/ubsan/TestCases/TypeCheck/vptr.cpp
@@ -23,7 +23,7 @@
 // RUN: %env_ubsan_opts=halt_on_error=1 not %run %t nN 2>&1 | FileCheck %s --check-prefix=CHECK-NULL-MEMFUN --strict-whitespace
 // RUN: %env_ubsan_opts=print_stacktrace=1 %run %t dT 2>&1 | FileCheck %s --check-prefix=CHECK-DYNAMIC --allow-unused-prefixes --check-prefix=CHECK-%os-DYNAMIC --strict-whitespace
 
-// RUN: (echo "vptr_check:S"; echo "vptr_check:T"; echo "vptr_check:U") > %t.supp
+// RUN: echo -e "vptr_check:S\nvptr_check:T\nvptr_check:U" > %t.supp
 // RUN: %env_ubsan_opts=halt_on_error=1:suppressions='"%t.supp"' %run %t mS
 // RUN: %env_ubsan_opts=halt_on_error=1:suppressions='"%t.supp"' %run %t fS
 // RUN: %env_ubsan_opts=halt_on_error=1:suppressions='"%t.supp"' %run %t cS


        


More information about the llvm-commits mailing list