[llvm] 085587e - Reland "[MLGO] Remove Python <3.8 from unsupported config (#106132)"

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 26 18:46:00 PDT 2024


Author: Aiden Grossman
Date: 2024-08-26T18:45:34-07:00
New Revision: 085587e1a9cdf1625efca61153a7dfe30946a6ce

URL: https://github.com/llvm/llvm-project/commit/085587e1a9cdf1625efca61153a7dfe30946a6ce
DIFF: https://github.com/llvm/llvm-project/commit/085587e1a9cdf1625efca61153a7dfe30946a6ce.diff

LOG: Reland "[MLGO] Remove Python <3.8 from unsupported config (#106132)"

This reverts commit c3776c11c26e5c0e27b772e6694e6c76f73ac9e8.

This relands commit a959d70eb5b6d47c0b32eb34fc409e50c01d722d.

This was originally causing bot failures on Python version 3.8.
This relanding fixes that by adjusting the relevant type annotations
that are not supported in earlier versions.

Added: 
    

Modified: 
    llvm/test/CodeGen/MLRegAlloc/Inputs/interactive_main.py

Removed: 
    llvm/test/CodeGen/MLRegAlloc/lit.local.cfg
    llvm/test/Transforms/Inline/ML/lit.local.cfg


################################################################################
diff  --git a/llvm/test/CodeGen/MLRegAlloc/Inputs/interactive_main.py b/llvm/test/CodeGen/MLRegAlloc/Inputs/interactive_main.py
index 53809b0a040086..1f62a5c6c9a3be 100644
--- a/llvm/test/CodeGen/MLRegAlloc/Inputs/interactive_main.py
+++ b/llvm/test/CodeGen/MLRegAlloc/Inputs/interactive_main.py
@@ -2,6 +2,7 @@
 import interactive_host
 import sys
 
+from typing import Sequence
 
 def main(args):
     # this advisor just picks the first legal register to evict, which is
@@ -9,7 +10,7 @@ def main(args):
     class Advisor:
         to_return = False
 
-        def advice(self, tensor_values: list[log_reader.TensorValue]):
+        def advice(self, tensor_values: Sequence[log_reader.TensorValue]):
             for tv in tensor_values:
                 if tv.spec().name != "mask":
                     continue

diff  --git a/llvm/test/CodeGen/MLRegAlloc/lit.local.cfg b/llvm/test/CodeGen/MLRegAlloc/lit.local.cfg
deleted file mode 100644
index e8c7912650cb8e..00000000000000
--- a/llvm/test/CodeGen/MLRegAlloc/lit.local.cfg
+++ /dev/null
@@ -1,3 +0,0 @@
-import sys
-
-config.unsupported = sys.version_info.minor <= 8

diff  --git a/llvm/test/Transforms/Inline/ML/lit.local.cfg b/llvm/test/Transforms/Inline/ML/lit.local.cfg
deleted file mode 100644
index e8c7912650cb8e..00000000000000
--- a/llvm/test/Transforms/Inline/ML/lit.local.cfg
+++ /dev/null
@@ -1,3 +0,0 @@
-import sys
-
-config.unsupported = sys.version_info.minor <= 8


        


More information about the llvm-commits mailing list