[compiler-rt] [compiler-rt][test] Add REQUIRES: shell to focus-function.test with for-loop (PR #106150)

via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 26 16:39:25 PDT 2024


https://github.com/Harini0924 updated https://github.com/llvm/llvm-project/pull/106150

>From 3da511f1c71ea480a0c4065f8c0ef04a82930feb Mon Sep 17 00:00:00 2001
From: Harini <harinidonthula at google.com>
Date: Mon, 26 Aug 2024 21:57:43 +0000
Subject: [PATCH 1/2] Add REQUIRES: shell to focus-function.test

This patch add REQUIRES: shell to focus-function.test because lit internal shell
can't support the for loop syntax in this test.
---
 compiler-rt/test/fuzzer/focus-function.test | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/compiler-rt/test/fuzzer/focus-function.test b/compiler-rt/test/fuzzer/focus-function.test
index ec4a03c95a6355..09a64b043afc11 100644
--- a/compiler-rt/test/fuzzer/focus-function.test
+++ b/compiler-rt/test/fuzzer/focus-function.test
@@ -1,7 +1,7 @@
 # Tests -focus_function
 #
 # TODO: don't require linux.
-# REQUIRES: linux
+# REQUIRES: shell, linux
 UNSUPPORTED: target=aarch64{{.*}}
 
 RUN: %cpp_compiler %S/OnlySomeBytesTest.cpp -o %t-exe

>From a199e779aa886491fd15c9363274fe328190b2f6 Mon Sep 17 00:00:00 2001
From: Harini <harinidonthula at google.com>
Date: Mon, 26 Aug 2024 23:37:33 +0000
Subject: [PATCH 2/2] Added a comment saying why the file needs REQUIRES:
 shell.

---
 compiler-rt/test/fuzzer/focus-function.test | 1 +
 1 file changed, 1 insertion(+)

diff --git a/compiler-rt/test/fuzzer/focus-function.test b/compiler-rt/test/fuzzer/focus-function.test
index 09a64b043afc11..64fd5eebb23892 100644
--- a/compiler-rt/test/fuzzer/focus-function.test
+++ b/compiler-rt/test/fuzzer/focus-function.test
@@ -1,6 +1,7 @@
 # Tests -focus_function
 #
 # TODO: don't require linux.
+# Requires full shell support for the `for` loop syntax.
 # REQUIRES: shell, linux
 UNSUPPORTED: target=aarch64{{.*}}
 



More information about the llvm-commits mailing list