[llvm] [llvm-lit] Fix `TypeError` string argument expected in lit's internal shell (PR #105925)

Alexander Richardson via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 26 16:32:20 PDT 2024


================
@@ -413,7 +413,7 @@ def maybeUnescape(arg):
         for arg in args[:-1]:
             stdout.write(encode(maybeUnescape(arg)))
             stdout.write(encode(" "))
-        stdout.write(encode(maybeUnescape(args[-1])))
+        stdout.write(encode(maybeUnescape(str(args[-1]))))
----------------
arichardson wrote:

Conceptually, this seems like the wrong place to work around this problem. I would imagine the shell should expand globs before invoking any commands. Only doing it for the last one also seems odd - I guess that't the only case triggered by the current test suite, but surely we can construct inputs that have glob patterns elsewhere?

https://github.com/llvm/llvm-project/pull/105925


More information about the llvm-commits mailing list