[compiler-rt] [llvm] [llvm-lit][test] Resolved typo in raising InternalShellError for export command in lit's internal shell (PR #105961)

Paul Kirth via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 26 13:50:57 PDT 2024


================
@@ -356,7 +356,7 @@ def executeBuiltinPopd(cmd, shenv):
 def executeBuiltinExport(cmd, shenv):
     """executeBuiltinExport - Set an environment variable."""
     if len(cmd.args) != 2:
-        raise InternalShellError("'export' supports only one argument")
+        raise InternalShellError(cmd, "'export' supports only one argument")
----------------
ilovepi wrote:

Your change literally only affects the error message, so I don't think that's required. As long as other tests are passing/failing the same as before your patch then I don't think you need to update the world. Now, it would be nice to improve the state of testing, but that shouldn't block you from making the error consistent.

https://github.com/llvm/llvm-project/pull/105961


More information about the llvm-commits mailing list