[compiler-rt] [llvm] [compiler-rt][test] Resolved export command failure in test run with lit's internal shell (PR #105961)
Connie Zhu via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 26 13:46:51 PDT 2024
================
@@ -356,7 +356,7 @@ def executeBuiltinPopd(cmd, shenv):
def executeBuiltinExport(cmd, shenv):
"""executeBuiltinExport - Set an environment variable."""
if len(cmd.args) != 2:
- raise InternalShellError("'export' supports only one argument")
+ raise InternalShellError(cmd, "'export' supports only one argument")
----------------
connieyzhu wrote:
I created the test in my latest change. I only made a test to show the failing behavior that is used here, but I wasn't sure if I should make tests to show that the export command works. There are other lit tests that use the export command, which do show to some extent that the command works. Do you think that's enough, or should I add more tests?
https://github.com/llvm/llvm-project/pull/105961
More information about the llvm-commits
mailing list