[compiler-rt] [rtsan][compiler-rt] Disable file permissions test causing build failure (PR #106079)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 26 07:15:05 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-compiler-rt-sanitizer
Author: Chris Apple (cjappl)
<details>
<summary>Changes</summary>
Related to: ca95bee64972, #<!-- -->105732
---
Full diff: https://github.com/llvm/llvm-project/pull/106079.diff
1 Files Affected:
- (modified) compiler-rt/lib/rtsan/tests/rtsan_test_interceptors.cpp (+19-13)
``````````diff
diff --git a/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors.cpp b/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors.cpp
index 47c07b3e47abd7..5b88cf64612942 100644
--- a/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors.cpp
+++ b/compiler-rt/lib/rtsan/tests/rtsan_test_interceptors.cpp
@@ -184,19 +184,25 @@ TEST_F(RtsanFileTest, OpenatDiesWhenRealtime) {
ExpectNonRealtimeSurvival(func);
}
-TEST_F(RtsanFileTest, OpenCreatesFileWithProperMode) {
- const int mode = S_IRGRP | S_IROTH | S_IRUSR | S_IWUSR;
-
- const int fd = open(GetTemporaryFilePath(), O_CREAT | O_WRONLY, mode);
- ASSERT_THAT(fd, Ne(-1));
- close(fd);
-
- struct stat st;
- ASSERT_THAT(stat(GetTemporaryFilePath(), &st), Eq(0));
-
- // Mask st_mode to get permission bits only
- ASSERT_THAT(st.st_mode & 0777, Eq(mode));
-}
+// FIXME: This fails on the build machines, but not locally!
+// see https://github.com/llvm/llvm-project/pull/105732#issuecomment-2310286530
+// Value of: st.st_mode & 0777
+// Expected: is equal to 420
+// Actual: 384
+// TEST_F(RtsanFileTest, OpenCreatesFileWithProperMode) {
+// const int mode = S_IRGRP | S_IROTH | S_IRUSR | S_IWUSR;
+//
+// const int fd = open(GetTemporaryFilePath(), O_CREAT | O_WRONLY, mode);
+// ASSERT_THAT(fd, Ne(-1));
+// close(fd);
+//
+// struct stat st;
+// ASSERT_THAT(stat(GetTemporaryFilePath(), &st), Eq(0));
+//
+// // Mask st_mode to get permission bits only
+//
+// //ASSERT_THAT(st.st_mode & 0777, Eq(mode)); FAILED ASSERTION
+// }
TEST_F(RtsanFileTest, CreatDiesWhenRealtime) {
auto func = [this]() { creat(GetTemporaryFilePath(), S_IWOTH | S_IROTH); };
``````````
</details>
https://github.com/llvm/llvm-project/pull/106079
More information about the llvm-commits
mailing list