[llvm] [NFC] Remove dead code (PR #106056)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 26 04:03:12 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-amdgpu
Author: None (ldrumm)
<details>
<summary>Changes</summary>
There's an early exit branch a couple of lines earlier for `MVT == f64`. Convert to an assert rather than using the duplicate ternary here. This silences an opinionated static analyser that's been bugging me.
---
Full diff: https://github.com/llvm/llvm-project/pull/106056.diff
1 Files Affected:
- (modified) llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp (+2-2)
``````````diff
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp b/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp
index cb3fbdb850c1ac..4cf7733a260ff0 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp
@@ -745,8 +745,8 @@ GCNTTIImpl::getIntrinsicInstrCost(const IntrinsicCostAttributes &ICA,
case Intrinsic::copysign:
return NElts * getFullRateInstrCost();
case Intrinsic::canonicalize: {
- InstRate =
- SLT == MVT::f64 ? get64BitInstrCost(CostKind) : getFullRateInstrCost();
+ assert(SLT != MVT::f64);
+ InstRate = getFullRateInstrCost();
break;
}
case Intrinsic::uadd_sat:
``````````
</details>
https://github.com/llvm/llvm-project/pull/106056
More information about the llvm-commits
mailing list