[llvm] [GlobalIsel] Visit ICmp (PR #105991)

[Nikita Popov via llvm-commits]

Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/105991 at github.com>


https://github.com/nikic commented:

I don't have time to review GlobalISel changes, but I'll say this: Transforms from the middle-end optimizer should only be reimplemented in GlobalISel (or SDAG) if the patterns can plausibly be introduced as a result of legalization. The input to ISel is always assumed to be canonical IR, so anything taken care of by middle-end canonicalization does not need to be handled by GlobalISel (unless GlobalISel itself can introduce the pattern, e.g. via legalization).

https://github.com/llvm/llvm-project/pull/105991