[llvm] dff3c96 - [AMDGPU] Fix -Wpessimizing-move in AMDGPUSwLowerLDS.cpp (NFC)

Jie Fu via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 25 20:39:44 PDT 2024


Author: Jie Fu
Date: 2024-08-26T11:38:40+08:00
New Revision: dff3c9614144012afc51e0d5455512e4974c6ced

URL: https://github.com/llvm/llvm-project/commit/dff3c9614144012afc51e0d5455512e4974c6ced
DIFF: https://github.com/llvm/llvm-project/commit/dff3c9614144012afc51e0d5455512e4974c6ced.diff

LOG: [AMDGPU] Fix -Wpessimizing-move in AMDGPUSwLowerLDS.cpp (NFC)

/llvm-project/llvm/lib/Target/AMDGPU/AMDGPUSwLowerLDS.cpp:260:10:
error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
  return std::move(OrderedKernels);
         ^
/llvm-project/llvm/lib/Target/AMDGPU/AMDGPUSwLowerLDS.cpp:260:10: note: remove std::move call here
  return std::move(OrderedKernels);
         ^~~~~~~~~~              ~
1 error generated.

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/AMDGPUSwLowerLDS.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/AMDGPUSwLowerLDS.cpp b/llvm/lib/Target/AMDGPU/AMDGPUSwLowerLDS.cpp
index d2ff7a154d0df5..b2ab7e9c03e528 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUSwLowerLDS.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUSwLowerLDS.cpp
@@ -257,7 +257,7 @@ SetVector<Function *> AMDGPUSwLowerLDS::getOrderedIndirectLDSAccessingKernels(
     Func->setMetadata("llvm.amdgcn.lds.kernel.id",
                       MDNode::get(Ctx, AttrMDArgs));
   }
-  return std::move(OrderedKernels);
+  return OrderedKernels;
 }
 
 void AMDGPUSwLowerLDS::getNonKernelsWithLDSArguments(const CallGraph &CG) {


        


More information about the llvm-commits mailing list