[llvm] [Mips] Use a range-based for loop (NFC) (PR #106004)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Sun Aug 25 12:33:34 PDT 2024
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/106004
None
>From 8525ca71525c2ca9ceb0ccc209f7d5ceabc532d5 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Sun, 25 Aug 2024 12:20:52 -0700
Subject: [PATCH] [Mips] Use a range-based for loop (NFC)
---
.../Target/Mips/MipsConstantIslandPass.cpp | 26 +++++++++----------
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/llvm/lib/Target/Mips/MipsConstantIslandPass.cpp b/llvm/lib/Target/Mips/MipsConstantIslandPass.cpp
index b2ba0f8fe74dc9..311b73710fb7a1 100644
--- a/llvm/lib/Target/Mips/MipsConstantIslandPass.cpp
+++ b/llvm/lib/Target/Mips/MipsConstantIslandPass.cpp
@@ -1631,28 +1631,26 @@ MipsConstantIslands::fixupConditionalBr(ImmBranch &Br) {
void MipsConstantIslands::prescanForConstants() {
for (MachineBasicBlock &B : *MF) {
- for (MachineBasicBlock::instr_iterator I = B.instr_begin(),
- EB = B.instr_end();
- I != EB; ++I) {
- switch(I->getDesc().getOpcode()) {
+ for (MachineInstr &MI : B) {
+ switch (MI.getDesc().getOpcode()) {
case Mips::LwConstant32: {
PrescannedForConstants = true;
- LLVM_DEBUG(dbgs() << "constant island constant " << *I << "\n");
- LLVM_DEBUG(dbgs() << "num operands " << I->getNumOperands() << "\n");
- MachineOperand &Literal = I->getOperand(1);
+ LLVM_DEBUG(dbgs() << "constant island constant " << MI << "\n");
+ LLVM_DEBUG(dbgs() << "num operands " << MI.getNumOperands() << "\n");
+ MachineOperand &Literal = MI.getOperand(1);
if (Literal.isImm()) {
int64_t V = Literal.getImm();
LLVM_DEBUG(dbgs() << "literal " << V << "\n");
Type *Int32Ty = Type::getInt32Ty(MF->getFunction().getContext());
const Constant *C = ConstantInt::get(Int32Ty, V);
unsigned index = MCP->getConstantPoolIndex(C, Align(4));
- I->getOperand(2).ChangeToImmediate(index);
- LLVM_DEBUG(dbgs() << "constant island constant " << *I << "\n");
- I->setDesc(TII->get(Mips::LwRxPcTcp16));
- I->removeOperand(1);
- I->removeOperand(1);
- I->addOperand(MachineOperand::CreateCPI(index, 0));
- I->addOperand(MachineOperand::CreateImm(4));
+ MI.getOperand(2).ChangeToImmediate(index);
+ LLVM_DEBUG(dbgs() << "constant island constant " << MI << "\n");
+ MI.setDesc(TII->get(Mips::LwRxPcTcp16));
+ MI.removeOperand(1);
+ MI.removeOperand(1);
+ MI.addOperand(MachineOperand::CreateCPI(index, 0));
+ MI.addOperand(MachineOperand::CreateImm(4));
}
break;
}
More information about the llvm-commits
mailing list