[compiler-rt] [compiler-rt][tests] Removed the use of parentheses in compiler-rt tests with lit internal shell (PR #105729)
Paul Kirth via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 23 10:21:23 PDT 2024
================
@@ -23,7 +23,9 @@
// RUN: %env_ubsan_opts=halt_on_error=1 not %run %t nN 2>&1 | FileCheck %s --check-prefix=CHECK-NULL-MEMFUN --strict-whitespace
// RUN: %env_ubsan_opts=print_stacktrace=1 %run %t dT 2>&1 | FileCheck %s --check-prefix=CHECK-DYNAMIC --allow-unused-prefixes --check-prefix=CHECK-%os-DYNAMIC --strict-whitespace
-// RUN: (echo "vptr_check:S"; echo "vptr_check:T"; echo "vptr_check:U") > %t.supp
+// RUN: echo "vptr_check:S" > %t.supp
+// RUN: echo "vptr_check:T" >> %t.supp
+// RUN: echo "vptr_check:U" >> %t.supp
----------------
ilovepi wrote:
split-file is probably overkill here, but its a pattern we use elsewhere. If we can avoid 2 subshell invocations w/o losing much (if any) readability, we probably should try to do that, IMO. It isn't a huge performance win, but I don't find it much more readable split onto 3 lines w/ file redirection than spelled out as a single `echo`, and we may as well be a little bit more efficient.
https://github.com/llvm/llvm-project/pull/105729
More information about the llvm-commits
mailing list