[llvm] aec3ec0 - [SCCP] fix non-determinism (#105758)

via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 23 09:45:45 PDT 2024


Author: Florian Mayer
Date: 2024-08-23T09:45:42-07:00
New Revision: aec3ec04ac611f9a3d1e1ad075d50f62c1d1a1e2

URL: https://github.com/llvm/llvm-project/commit/aec3ec04ac611f9a3d1e1ad075d50f62c1d1a1e2
DIFF: https://github.com/llvm/llvm-project/commit/aec3ec04ac611f9a3d1e1ad075d50f62c1d1a1e2.diff

LOG: [SCCP] fix non-determinism (#105758)

the visit order depended on hashing because we iterated over a
SmallPtrSet

Added: 
    

Modified: 
    llvm/lib/Transforms/Utils/SCCPSolver.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Utils/SCCPSolver.cpp b/llvm/lib/Transforms/Utils/SCCPSolver.cpp
index 40f0f04c323ddc..670d88ac7cf8fa 100644
--- a/llvm/lib/Transforms/Utils/SCCPSolver.cpp
+++ b/llvm/lib/Transforms/Utils/SCCPSolver.cpp
@@ -13,6 +13,7 @@
 //===----------------------------------------------------------------------===//
 
 #include "llvm/Transforms/Utils/SCCPSolver.h"
+#include "llvm/ADT/SetVector.h"
 #include "llvm/Analysis/ConstantFolding.h"
 #include "llvm/Analysis/InstructionSimplify.h"
 #include "llvm/Analysis/ValueLattice.h"
@@ -418,7 +419,7 @@ class SCCPInstVisitor : public InstVisitor<SCCPInstVisitor> {
 
   DenseMap<Function *, std::unique_ptr<PredicateInfo>> FnPredicateInfo;
 
-  DenseMap<Value *, SmallPtrSet<User *, 2>> AdditionalUsers;
+  DenseMap<Value *, SmallSetVector<User *, 2>> AdditionalUsers;
 
   LLVMContext &Ctx;
 


        


More information about the llvm-commits mailing list