[compiler-rt] Found one more delta to unbreak build for z/os (PR #82789)

Sean Perry via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 23 07:53:24 PDT 2024


================
@@ -383,10 +383,10 @@ static __inline fp_t __compiler_rt_fmax(fp_t x, fp_t y) {
 #endif
 }
 
-#elif defined(QUAD_PRECISION) && defined(CRT_HAS_TF_MODE)
+#elif defined(QUAD_PRECISION)
+#if defined(CRT_HAS_TF_MODE) && defined(CRT_HAS_IEEE_TF)
----------------
perry-ca wrote:

Thanks for the update.

Also look at the compiler side.  Can the compiler generate calls to `__divtc3` and `__multc3` or any of the TF functions?  If the compiler can't generate a call to these TF functions then it is ok to remove them from the archive even though LLVM 17 had them in it.  I'd also look at what code would be in the `__divtc3` in LLVM 17 if you can't provide that logfb function.  How did that file compile in the first place?

When making your patch can you start with this change so we are building on top of the same code.  And when you are ready ping me and I will try your change on z/OS.

https://github.com/llvm/llvm-project/pull/82789


More information about the llvm-commits mailing list