[llvm] [LTO] Use a helper function to add a definition (NFC) (PR #105721)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 22 12:30:32 PDT 2024


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/105721

I missed this one when I introduced helper functions in:

  commit 3082a381f57ef2885c270f41f2955e08c79634c5
  Author: Kazu Hirata <kazu at google.com>
  Date:   Thu Aug 22 12:06:47 2024 -0700


>From c54aa0fa6175feb47983e48edc273b6fff1be97e Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Thu, 22 Aug 2024 12:20:41 -0700
Subject: [PATCH] [LTO] Use a helper function to add a definition (NFC)

I missed this one when I introduced helper functions in:

  commit 3082a381f57ef2885c270f41f2955e08c79634c5
  Author: Kazu Hirata <kazu at google.com>
  Date:   Thu Aug 22 12:06:47 2024 -0700
---
 llvm/lib/Transforms/IPO/FunctionImport.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/lib/Transforms/IPO/FunctionImport.cpp b/llvm/lib/Transforms/IPO/FunctionImport.cpp
index 354ad0fde092a7..55803670071d16 100644
--- a/llvm/lib/Transforms/IPO/FunctionImport.cpp
+++ b/llvm/lib/Transforms/IPO/FunctionImport.cpp
@@ -600,8 +600,8 @@ class WorkloadImportsManager : public ModuleImportsManager {
       LLVM_DEBUG(dbgs() << "[Workload][Including]" << VI.name() << " from "
                         << ExportingModule << " : "
                         << Function::getGUID(VI.name()) << "\n");
-      ImportList[ExportingModule][VI.getGUID()] =
-          GlobalValueSummary::Definition;
+      FunctionImporter::addDefinition(ImportList, ExportingModule,
+                                      VI.getGUID());
       GVI.onImportingSummary(*GVS);
       if (ExportLists)
         (*ExportLists)[ExportingModule].insert(VI);



More information about the llvm-commits mailing list