[llvm] [CGP] [CodeGenPrepare] Folding `urem` with loop invariant value plus offset (PR #104724)

via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 22 10:34:16 PDT 2024


goldsteinn wrote:

> > @dtcxzyw Does this pattern exist?
> 
> Add: abc/giaSimBase.c.ll DisjointOr: none Sub: none
> 
> > I can imagine the `add` variant might, but `sub` and `or disjoint` are unnecessary generalization.
> 
> Agree.

If I change the simplification code to just use `simplifyBinOp` is the minimal complexity okay to keep `or disjoint` (and potentially `sub`)?

Dropping in meantime.

https://github.com/llvm/llvm-project/pull/104724


More information about the llvm-commits mailing list