[llvm] b2cd81c - [IR] Simplify comparisons with std::optional (NFC) (#105624)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 22 10:19:58 PDT 2024
Author: Kazu Hirata
Date: 2024-08-22T10:19:56-07:00
New Revision: b2cd81c93831fe256bddec5efa5a2765400076de
URL: https://github.com/llvm/llvm-project/commit/b2cd81c93831fe256bddec5efa5a2765400076de
DIFF: https://github.com/llvm/llvm-project/commit/b2cd81c93831fe256bddec5efa5a2765400076de.diff
LOG: [IR] Simplify comparisons with std::optional (NFC) (#105624)
For variable X of type std::optional, X && X.value_or(Y) == Z is
equivalent to X == Z when Y != Z.
Added:
Modified:
llvm/lib/IR/VectorBuilder.cpp
Removed:
################################################################################
diff --git a/llvm/lib/IR/VectorBuilder.cpp b/llvm/lib/IR/VectorBuilder.cpp
index 8dbf25277bf5d2..b8f56a7a2e5f9b 100644
--- a/llvm/lib/IR/VectorBuilder.cpp
+++ b/llvm/lib/IR/VectorBuilder.cpp
@@ -96,8 +96,7 @@ Value *VectorBuilder::createVectorInstructionImpl(Intrinsic::ID VPID,
// Insert mask and evl operands in between the instruction operands.
for (size_t VPParamIdx = 0, ParamIdx = 0; VPParamIdx < NumVPParams;
++VPParamIdx) {
- if ((MaskPosOpt && MaskPosOpt.value_or(NumVPParams) == VPParamIdx) ||
- (VLenPosOpt && VLenPosOpt.value_or(NumVPParams) == VPParamIdx))
+ if (MaskPosOpt == VPParamIdx || VLenPosOpt == VPParamIdx)
continue;
assert(ParamIdx < NumInstParams);
IntrinParams[VPParamIdx] = InstOpArray[ParamIdx++];
More information about the llvm-commits
mailing list