[llvm] VPlan: increase simplification power of simplifyRecipe (PR #93998)
Ramkumar Ramachandra via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 22 10:10:25 PDT 2024
artagnon wrote:
> > > If it is not too much extra work, it would probably also be good to introduce the worklist as NFC commit without test changes and then replace the patterns.
> >
> >
> > Not sure what you mean by introducing the worklist as an NFC. Doesn't the introduction of worklist mean that we return candidates for further simplification, reducing recursively, and by definition, the change has higher simplification power? I might be able to introduce the worklist without any _test changes_, that isn't technically an NFC, with some difficulty; however, I don't see the value of such a patch.
>
> Ah Right, probably not entirely NFC, the main point would be to separate introducing the worklist from also adjusting the patterns, which should hopefully be fairly straigth-forward to separate as 2 distinct patches (the PR title already implies that the PR introduces a worklist only)
Thanks, it was much simpler than I originally thought.
https://github.com/llvm/llvm-project/pull/93998
More information about the llvm-commits
mailing list