[compiler-rt] [compiler-rt][test] Added REQUIRES:shell to fuzzer test with for-loop (PR #105557)

Connie Zhu via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 21 15:18:51 PDT 2024


https://github.com/connieyzhu updated https://github.com/llvm/llvm-project/pull/105557

>From 24ba7431c13d9e59eaf9f17044685d9a5f506e61 Mon Sep 17 00:00:00 2001
From: Connie Zhu <connieyzhu at google.com>
Date: Wed, 21 Aug 2024 17:21:51 +0000
Subject: [PATCH 1/2] [compiler-rt][test] Added REQUIRES:shell to fuzzer test
 with for-loop

This patch makes the features_dir.test file require a shell when
running. This will make the test file unsupported when running llvm-lit with
its internal shell implementation, which is enabled by turning on the
LIT_USE_INTERNAL_SHELL environment variable. Lit's internal shell
currently does not support for-loop syntax.
---
 compiler-rt/test/fuzzer/features_dir.test | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/compiler-rt/test/fuzzer/features_dir.test b/compiler-rt/test/fuzzer/features_dir.test
index c6beec01bc3ab2..9298fdace6cd7c 100644
--- a/compiler-rt/test/fuzzer/features_dir.test
+++ b/compiler-rt/test/fuzzer/features_dir.test
@@ -1,5 +1,5 @@
 # Tests -features_dir=F
-# REQUIRES: linux
+# REQUIRES: shell
 RUN: %cpp_compiler %S/SimpleTest.cpp -o %t-SimpleTest
 RUN: rm -rf %t-C %t-F
 RUN: mkdir %t-C %t-F

>From 6ecb1fa5d0145923a7ee8b99c2e410e77a7e4944 Mon Sep 17 00:00:00 2001
From: Connie Zhu <connieyzhu at google.com>
Date: Wed, 21 Aug 2024 22:18:04 +0000
Subject: [PATCH 2/2] [compiler-rt][test] Add back REQUIRES: linux

---
 compiler-rt/test/fuzzer/features_dir.test | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/compiler-rt/test/fuzzer/features_dir.test b/compiler-rt/test/fuzzer/features_dir.test
index 9298fdace6cd7c..ce63b3920708cc 100644
--- a/compiler-rt/test/fuzzer/features_dir.test
+++ b/compiler-rt/test/fuzzer/features_dir.test
@@ -1,5 +1,5 @@
 # Tests -features_dir=F
-# REQUIRES: shell
+# REQUIRES: linux, shell
 RUN: %cpp_compiler %S/SimpleTest.cpp -o %t-SimpleTest
 RUN: rm -rf %t-C %t-F
 RUN: mkdir %t-C %t-F



More information about the llvm-commits mailing list